Skip to content

upcoming: [M3-9785, M3-9788, M3-10040] - Added NodeBalacer Table and replace Linodes with Resources and remove "Label" text from Subnet and Linode Column #12232

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

hasyed-akamai
Copy link
Contributor

@hasyed-akamai hasyed-akamai commented May 16, 2025

Description

  • This PR adds a NodeBalancer Table section under the Subnet table present in VPC Details.
  • This PR replaces the Linodes text with Resources text.

Changes

  • Introduced a new NodeBalancer Table section under the Subnet table present in VPC Details to display associated NodeBalancer information.
  • This PR replaces the Linodes text with Resources text.
  • Added unit test for the NodeBalancer Table Section.

Target Release Date

N/A

Preview

Before After
Before After
Before After
Before After
Before After
Before After

How to Test

🛠 Prerequisites

  • Add the required customer tags in Admin (mentioned in the ticket).
  • Enable the VPC feature flag in Cloud Manager (CM) (mentioned in the ticket).

🧪 Option 1: Using API

  • Create a NodeBalancer via API and associate it with the created VPC (mentioned in the ticket).
  • Go to the VPC Details page (on this PR’s branch) and verify that the NodeBalancer Table section appears under the Subnet table with the correct information.
  • Verify the Linodes text in VPC Landing table column VPC Summary section VPC Subnet table column has been replaced with the Resources.

🧪 Option 2: Using UI

  • Check out this PR that enables NodeBalancer creation with VPC support in the UI.
  • Create a NodeBalancer with a VPC using that UI.
  • Return to this PR’s branch, navigate to the VPC Details page, and verify that the NodeBalancer Table section appears under the Subnet table with the correct information.
  • Verify the Linodes text in VPC Landing table column VPC Summary section VPC Subnet table column has been replaced with the Resources.
Author Checklists

As an Author, I considered:

  • Self-review
  • Contribution guidelines
  • Small, focused PR
  • Changeset added if needed
  • Tests added or updated
  • No sensitive info
  • Feature flag if needed
  • Reproduction steps
  • Docs updated if needed
  • Mobile and a11y support

Before moving from Draft to Open:

  • All unit tests passing
  • TypeScript compiles
  • Linting passes

@hasyed-akamai hasyed-akamai self-assigned this May 16, 2025
@hasyed-akamai hasyed-akamai added the NB-VPC Relating to NodeBalancer-VPC integration label May 16, 2025
@hasyed-akamai hasyed-akamai force-pushed the M3-9785-M3-9788-add-nodebalancer-table-and-replace-linodes-with-resources branch from 7b5cd7e to 01176b5 Compare May 16, 2025 08:35
@hasyed-akamai hasyed-akamai force-pushed the M3-9785-M3-9788-add-nodebalancer-table-and-replace-linodes-with-resources branch from b249cec to 4c0cdbb Compare May 19, 2025 09:04
@hasyed-akamai hasyed-akamai force-pushed the M3-9785-M3-9788-add-nodebalancer-table-and-replace-linodes-with-resources branch from ac0ede2 to 1ce71d6 Compare May 20, 2025 08:11
@hasyed-akamai hasyed-akamai marked this pull request as ready for review May 20, 2025 11:55
@hasyed-akamai hasyed-akamai requested review from a team as code owners May 20, 2025 11:55
@hasyed-akamai hasyed-akamai requested review from dmcintyr-akamai, mjac0bs and abailly-akamai and removed request for a team May 20, 2025 11:55
abailly-akamai

This comment was marked as resolved.

@mjac0bs
Copy link
Contributor

mjac0bs commented May 21, 2025

it appears validation is not working properly when trying to create it. See video below, clicking on the create button does nothing, so i can't test the rest of the flows. What am i doing wrong?

@abailly-akamai Do you happen to be missing the customer tag? It's mentioned in the prerequisites, but not listed anywhere I can find, project tracker or otherwise. I believe it's nb-vpc. I happen to have it because of LKE-E. Creating a NB with a VPC works for me, but I observed the inability to submit when I removed it.

Copy link
Contributor

@abailly-akamai abailly-akamai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was able to confirm the UI after adding customer tags. Looks good ✅

Approving pending small fixes and answering questions

@dabaka
Copy link

dabaka commented May 22, 2025

@hasyed-akamai - Need to verify the Resources word with CX.

This PR replaces the Linodes text with Resources text.

@dabaka
Copy link

dabaka commented May 22, 2025

@hasyed-akamai - Need to verify the Resources word with CX.

This PR replaces the Linodes text with Resources text.

@hasyed-akamai @harsh-akamai - Met with UX and Tech Writing and we have decided to go ahead with 'Resources' to provide the most reasonable UX in this important VPC context.

IAM and other APIs are using the term 'Entity', but while it make sense for their specific use cases, it would cause uncertainty in VPC and 'Resource' is a very understood word industry wide and is precise to what we need it to mean. See: https://www.akamai.com/glossary/what-are-cloud-resources

While this is only a UI Label for now, we feel it is safe and we can change it if need. A wider conversation is happening to standardize (if it needs to be) generalized terminology for Akamai Cloud.

@cloudmanager Should we see 'Resource/s' becoming engrained beyond UI Labeling (eg. API specs) please let us know.

@github-project-automation github-project-automation bot moved this from Review to Approved in Cloud Manager May 22, 2025
@hasyed-akamai hasyed-akamai changed the title upcoming: [M3-9785, M3-9788] - Added NodeBalacer Table and replace Linodes with Resources upcoming: [M3-9785, M3-9788, 10040] - Added NodeBalacer Table and replace Linodes with Resources and remove "Label" text from Subnet and Linode Column May 23, 2025
@hasyed-akamai hasyed-akamai force-pushed the M3-9785-M3-9788-add-nodebalancer-table-and-replace-linodes-with-resources branch from e9edb4a to 4ebb83a Compare May 26, 2025 10:02
@harsh-akamai harsh-akamai changed the title upcoming: [M3-9785, M3-9788, 10040] - Added NodeBalacer Table and replace Linodes with Resources and remove "Label" text from Subnet and Linode Column upcoming: [M3-9785, M3-9788, M3-10040] - Added NodeBalacer Table and replace Linodes with Resources and remove "Label" text from Subnet and Linode Column May 28, 2025
Copy link
Contributor

@harsh-akamai harsh-akamai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good!
Could we have the error messages for the linode and nodebalancer table center aligned?

Errors misaligned

08_00_42

@hasyed-akamai
Copy link
Contributor Author

Thanks @harsh-akamai for pointing the error message alignment, i have fixed that in the new commit

Error Alignment

Screenshot 2025-05-28 at 8 16 29 PM

@linode-gh-bot
Copy link
Collaborator

Cloud Manager UI test results

🔺 2 failing tests on test run #33 ↗︎

❌ Failing✅ Passing↪️ Skipped🕐 Duration
2 Failing597 Passing10 Skipped99m 58s

Details

Failing Tests
SpecTest
access-key.e2e.spec.tsCloud Manager Cypress Tests→object storage access key end-to-end tests » object storage access key end-to-end tests
switch-linode-state.spec.tsCloud Manager Cypress Tests→switch linode state » switch linode state

Troubleshooting

Use this command to re-run the failing tests:

pnpm cy:run -s "cypress/e2e/core/objectStorage/access-key.e2e.spec.ts,cypress/e2e/core/linodes/switch-linode-state.spec.ts"

@dwiley-akamai dwiley-akamai self-requested a review May 28, 2025 17:19
@hasyed-akamai
Copy link
Contributor Author

Merging, e2e failures are unrelated.

@hasyed-akamai hasyed-akamai merged commit 9eff345 into linode:develop May 28, 2025
34 of 35 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Do Not Merge NB-VPC Relating to NodeBalancer-VPC integration Ready for Review
Projects
Status: Merged
Development

Successfully merging this pull request may close these issues.

7 participants