upcoming: [M3-9785, M3-9788, M3-10040] - Added NodeBalacer Table and replace Linodes with Resources and remove "Label" text from Subnet and Linode Column #12232

hasyed-akamai · 2025-05-16T08:35:38Z

Description

This PR adds a NodeBalancer Table section under the Subnet table present in VPC Details.
This PR replaces the Linodes text with Resources text.

Changes

Introduced a new NodeBalancer Table section under the Subnet table present in VPC Details to display associated NodeBalancer information.
This PR replaces the Linodes text with Resources text.
Added unit test for the NodeBalancer Table Section.

Target Release Date

N/A

Preview

Before	After

How to Test

🛠 Prerequisites

Add the required customer tags in Admin (mentioned in the ticket).
Enable the VPC feature flag in Cloud Manager (CM) (mentioned in the ticket).

🧪 Option 1: Using API

Create a NodeBalancer via API and associate it with the created VPC (mentioned in the ticket).
Go to the VPC Details page (on this PR’s branch) and verify that the NodeBalancer Table section appears under the Subnet table with the correct information.
Verify the Linodes text in VPC Landing table column VPC Summary section VPC Subnet table column has been replaced with the Resources.

🧪 Option 2: Using UI

Check out this PR that enables NodeBalancer creation with VPC support in the UI.
Create a NodeBalancer with a VPC using that UI.
Return to this PR’s branch, navigate to the VPC Details page, and verify that the NodeBalancer Table section appears under the Subnet table with the correct information.
Verify the Linodes text in VPC Landing table column VPC Summary section VPC Subnet table column has been replaced with the Resources.

Author Checklists

As an Author, I considered:

Before moving from Draft to Open:

All unit tests passing
TypeScript compiles
Linting passes

…nodes with Resources

…ace Linodes Text with Resources

…d-replace-linodes-with-resources

packages/manager/.changeset/pr-12232-upcoming-features-1747645656510.md

packages/manager/src/features/VPCs/VPCDetail/VPCDetail.tsx

packages/manager/src/features/VPCs/VPCLanding/VPCRow.tsx

packages/manager/src/features/VPCs/VPCDetail/VPCSubnetsTable.tsx

packages/manager/src/features/VPCs/VPCDetail/SubnetNodebalancerRow.tsx

mjac0bs · 2025-05-21T22:04:09Z

it appears validation is not working properly when trying to create it. See video below, clicking on the create button does nothing, so i can't test the rest of the flows. What am i doing wrong?

@abailly-akamai Do you happen to be missing the customer tag? It's mentioned in the prerequisites, but not listed anywhere I can find, project tracker or otherwise. I believe it's nb-vpc. I happen to have it because of LKE-E. Creating a NB with a VPC works for me, but I observed the inability to submit when I removed it.

abailly-akamai

Was able to confirm the UI after adding customer tags. Looks good ✅

Approving pending small fixes and answering questions

packages/manager/src/features/VPCs/VPCDetail/SubnetNodebalancerRow.tsx

packages/manager/src/features/VPCs/VPCDetail/VPCDetail.tsx

packages/manager/src/features/VPCs/VPCDetail/VPCSubnetsTable.tsx

…es in the unit and e2e tests

packages/manager/.changeset/pr-12232-upcoming-features-1747645656510.md

packages/manager/src/features/VPCs/VPCDetail/SubnetNodebalancerRow.tsx

dabaka · 2025-05-22T16:11:55Z

@hasyed-akamai - Need to verify the Resources word with CX.

This PR replaces the Linodes text with Resources text.

dabaka · 2025-05-22T20:54:21Z

@hasyed-akamai - Need to verify the Resources word with CX.

This PR replaces the Linodes text with Resources text.

@hasyed-akamai @harsh-akamai - Met with UX and Tech Writing and we have decided to go ahead with 'Resources' to provide the most reasonable UX in this important VPC context.

IAM and other APIs are using the term 'Entity', but while it make sense for their specific use cases, it would cause uncertainty in VPC and 'Resource' is a very understood word industry wide and is precise to what we need it to mean. See: https://www.akamai.com/glossary/what-are-cloud-resources

While this is only a UI Label for now, we feel it is safe and we can change it if need. A wider conversation is happening to standardize (if it needs to be) generalized terminology for Akamai Cloud.

@cloudmanager Should we see 'Resource/s' becoming engrained beyond UI Labeling (eg. API specs) please let us know.

packages/manager/src/features/VPCs/VPCDetail/SubnetNodebalancerRow.tsx

…ubnetLinodeRow

…d-replace-linodes-with-resources

harsh-akamai

Changes look good!
Could we have the error messages for the linode and nodebalancer table center aligned?

Errors misaligned

hasyed-akamai · 2025-05-28T14:50:31Z

Thanks @harsh-akamai for pointing the error message alignment, i have fixed that in the new commit

Error Alignment

…d-replace-linodes-with-resources

linode-gh-bot · 2025-05-28T17:15:14Z

Cloud Manager UI test results

🔺 2 failing tests on test run #33 ↗︎

❌ Failing	✅ Passing	↪️ Skipped	🕐 Duration
`2 Failing`	`597 Passing`	`10 Skipped`	`99m 58s`

Details

Failing Tests
	Spec	Test
❌	`access-key.e2e.spec.ts`	Cloud Manager Cypress Tests→object storage access key end-to-end tests » object storage access key end-to-end tests
❌	`switch-linode-state.spec.ts`	Cloud Manager Cypress Tests→switch linode state » switch linode state

Troubleshooting

Use this command to re-run the failing tests:

pnpm cy:run -s "cypress/e2e/core/objectStorage/access-key.e2e.spec.ts,cypress/e2e/core/linodes/switch-linode-state.spec.ts"

hasyed-akamai · 2025-05-28T18:13:22Z

Merging, e2e failures are unrelated.

hasyed-akamai requested a review from harsh-akamai May 16, 2025 08:35

hasyed-akamai self-assigned this May 16, 2025

hasyed-akamai added the NB-VPC Relating to NodeBalancer-VPC integration label May 16, 2025

github-project-automation bot added this to Cloud Manager May 16, 2025

github-project-automation bot moved this to Review in Cloud Manager May 16, 2025

hasyed-akamai force-pushed the M3-9785-M3-9788-add-nodebalancer-table-and-replace-linodes-with-resources branch from 7b5cd7e to 01176b5 Compare May 16, 2025 08:35

hasyed-akamai requested a review from dwiley-akamai May 16, 2025 08:37

hasyed-akamai added 2 commits May 19, 2025 14:34

upcoming: [M3-9785, M3-9788] - Added NodeBalacer Table and replace Li…

4616c72

…nodes with Resources

fix unit test and e2e

4c0cdbb

hasyed-akamai force-pushed the M3-9785-M3-9788-add-nodebalancer-table-and-replace-linodes-with-resources branch from b249cec to 4c0cdbb Compare May 19, 2025 09:04

hasyed-akamai added 2 commits May 19, 2025 14:37

Added changeset: Added NodeBalacer Table under Subnets Table and repl…

ce0d7b2

…ace Linodes Text with Resources

added unit tests for the SubnetNodebalancerRow component

1ce71d6

hasyed-akamai force-pushed the M3-9785-M3-9788-add-nodebalancer-table-and-replace-linodes-with-resources branch from ac0ede2 to 1ce71d6 Compare May 20, 2025 08:11

hasyed-akamai added 2 commits May 20, 2025 13:42

Merge branch 'develop' into M3-9785-M3-9788-add-nodebalancer-table-an…

6d83546

…d-replace-linodes-with-resources

fix unit tests

1922e5e

hasyed-akamai marked this pull request as ready for review May 20, 2025 11:55

hasyed-akamai requested review from a team as code owners May 20, 2025 11:55

hasyed-akamai requested review from dmcintyr-akamai, mjac0bs and abailly-akamai and removed request for a team May 20, 2025 11:55

hasyed-akamai added 4 commits May 20, 2025 17:27

Merge branch 'develop' into M3-9785-M3-9788-add-nodebalancer-table-an…

6756f29

…d-replace-linodes-with-resources

added full width for the table rows

24adfb3

fix e2e tests

4322931

Merge branch 'develop' into M3-9785-M3-9788-add-nodebalancer-table-an…

e3657fa

…d-replace-linodes-with-resources

This comment was marked as resolved.

Sign in to view

dwiley-akamai reviewed May 21, 2025

View reviewed changes

abailly-akamai approved these changes May 22, 2025

View reviewed changes

added a feature flag for the Linodes column and revert back the chang…

d95fa86

…es in the unit and e2e tests

mjac0bs reviewed May 22, 2025

View reviewed changes

mjac0bs approved these changes May 22, 2025

View reviewed changes

packages/manager/src/features/VPCs/VPCDetail/SubnetNodebalancerRow.tsx Show resolved Hide resolved

github-project-automation bot moved this from Review to Approved in Cloud Manager May 22, 2025

hasyed-akamai added the Do Not Merge label May 23, 2025

hasyed-akamai added 5 commits May 23, 2025 08:03

change changeset description and center loading and error state for s…

e4aa66a

…ubnetLinodeRow

added unit test for getUniqueResourcesFromSubnets utils

d13e78f

added unit test in for UI testing of Resources text

6cee89d

Merge branch 'develop' into M3-9785-M3-9788-add-nodebalancer-table-an…

f7f6019

…d-replace-linodes-with-resources

remove label text from subnet and linode column

4ebb83a

hasyed-akamai changed the title ~~upcoming: [M3-9785, M3-9788] - Added NodeBalacer Table and replace Linodes with Resources~~ upcoming: [M3-9785, M3-9788, 10040] - Added NodeBalacer Table and replace Linodes with Resources and remove "Label" text from Subnet and Linode Column May 23, 2025

hasyed-akamai force-pushed the M3-9785-M3-9788-add-nodebalancer-table-and-replace-linodes-with-resources branch from e9edb4a to 4ebb83a Compare May 26, 2025 10:02

hasyed-akamai added 2 commits May 26, 2025 15:59

fix unit test for vpcsubnetstable

d9062f2

Merge branch 'develop' into M3-9785-M3-9788-add-nodebalancer-table-an…

4bcf611

…d-replace-linodes-with-resources

hasyed-akamai added 2 commits May 28, 2025 12:04

update error state

248984e

Merge branch 'develop' into M3-9785-M3-9788-add-nodebalancer-table-an…

044c845

…d-replace-linodes-with-resources

harsh-akamai approved these changes May 28, 2025

View reviewed changes

align error message

2786be8

Merge branch 'develop' into M3-9785-M3-9788-add-nodebalancer-table-an…

b6bb539

…d-replace-linodes-with-resources

dwiley-akamai self-requested a review May 28, 2025 17:19

hasyed-akamai merged commit 9eff345 into linode:develop May 28, 2025
34 of 35 checks passed

This was referenced May 28, 2025

Release v1.143.0 - release → staging #12291

Merged

Release v1.143.0 - staging → master #12306

Merged

upcoming: [M3-9785, M3-9788, M3-10040] - Added NodeBalacer Table and replace Linodes with Resources and remove "Label" text from Subnet and Linode Column #12232

upcoming: [M3-9785, M3-9788, M3-10040] - Added NodeBalacer Table and replace Linodes with Resources and remove "Label" text from Subnet and Linode Column #12232

Uh oh!

Conversation

hasyed-akamai commented May 16, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Changes

Target Release Date

Preview

How to Test

🛠 Prerequisites

🧪 Option 1: Using API

🧪 Option 2: Using UI

As an Author, I considered:

Before moving from Draft to Open:

Uh oh!

This comment was marked as resolved.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

mjac0bs commented May 21, 2025

Uh oh!

abailly-akamai left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

dabaka commented May 22, 2025

Uh oh!

dabaka commented May 22, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

harsh-akamai left a comment

Choose a reason for hiding this comment

Uh oh!

hasyed-akamai commented May 28, 2025

Uh oh!

linode-gh-bot commented May 28, 2025

Cloud Manager UI test results

🔺 2 failing tests on test run #33 ↗︎

Details

Troubleshooting

Uh oh!

hasyed-akamai commented May 28, 2025

Uh oh!

Uh oh!

Uh oh!

hasyed-akamai commented May 16, 2025 •

edited

Loading

dabaka commented May 22, 2025 •

edited

Loading